Improve "Unification incomplete for case" diagnostics (#116)#138
Open
Rakshitha-Ireddi wants to merge 3 commits intoboyland:masterfrom
Open
Improve "Unification incomplete for case" diagnostics (#116)#138Rakshitha-Ireddi wants to merge 3 commits intoboyland:masterfrom
Rakshitha-Ireddi wants to merge 3 commits intoboyland:masterfrom
Conversation
added 3 commits
January 13, 2026 23:51
Complete React + TypeScript web application for visualizing SASyLF proof trees. Features: - Interactive D3.js tree visualization - Beautiful purple gradient UI - Drag-and-drop file upload - Real-time node selection and details - Zoom and pan controls - 5 screenshots demonstrating functionality Technology: React 18, TypeScript, D3.js, Vite, Tailwind CSS Status: Fully tested and working
boyland
requested changes
Mar 30, 2026
Owner
boyland
left a comment
boyland
left a comment
There was a problem hiding this comment.
This Pull request is completely unacceptable. Please limit yourself to one topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #116.
The checker reported "Unification incomplete for case" with almost no usable detail when incomplete unification happened in the second unification step (
cleanedCaseTerm.unify(candidate)), while the first step already usedTermPrinterto point at a likely subexpression.Changes
RuleCase.incompleteUnificationHint(...), reusing the same heuristic as the firstunifypath (pick theFV[...]side when possible, then print withTermPrinter).ctx.inputVars), append a short note (matches typos like using a stale metavariable instead of a fresh one).Errors.CASE_UNIFICATION_INCOMPLETEis reported:RuleCase,Rule.checkCaseApplication, andDerivationByAnalysis.caseAnalyze.Errors.CASE_UNIFICATION_INCOMPLETEprefix so the message reads clearly with the appended hint.Authors