Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR attempts to close #1829
As per the discussion in the original post, a new operator was added that implements the functionality of the Dictionary<TKey, TValue>.TryGetValue method.
In order to implement the functionality corresponding to
out Value, the output of this operator is of typeTuple<bool, TValue>. The first element will represent whether the key exists or not (usingContainsKeymethod via reflection), and the value will be fetched. In cases where the key does not exist, the default constructor will be used instead.A few open questions:
For ref types, the default constructor is ok since it will return "null", for value types, we will return the default instead of the corresponding nullable type. I think this preferred than to build the nullable type.
I believe it would be better to call the "Value", "Key" to make it identical to the c# docs, but I couldnt find a way to override the property name