Open
Conversation
Owner
|
Thanks for your great work. I think your approach is more rigorous and preferable, but since size is defined with the following interface and writing '50%' is interpreted as a percentage, it may make sense to align the policy with that. Specifically, how about defining it like position?: { x: (number | string), y: (number | string) };, so that, just like size, writing 50% would enable percentage-based values? That would also keep the design consistent with size. |
Author
|
@bokuweb I like that idea, makes it much more intuitive when it's aligned like that! Changes have been added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed solution
Fixes #651 by adding support for percentages.
Tradeoffs
No known ones
Testing Done
Works nicely, also added a new storybook section for this