-
-
Notifications
You must be signed in to change notification settings - Fork 335
Fixes #651 Add percentage support #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||||
| { | ||||||
| "name": "react-rnd", | ||||||
| "version": "10.5.2", | ||||||
| "version": "10.5.3", | ||||||
|
||||||
| "version": "10.5.3", | |
| "version": "10.6.0", |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -104,6 +104,8 @@ export type HandleComponent = { | |||||
| topLeft?: React.ReactElement<any>; | ||||||
| } | ||||||
|
|
||||||
| export type PositionUnit = 'px' | '%'; | ||||||
|
||||||
| export type PositionUnit = 'px' | '%'; | |
| export type PositionUnit = 'px' | '%' | 'grid'; |
Copilot
AI
Feb 23, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Flow type definitions are missing several critical types and signatures required for the grid feature. The Props type is missing sizeUnit, gridConfig, and layoutMode properties. Additionally, position and size don't support the grid types (GridPosition and GridSize). The default property also doesn't support RndDefaultGrid. These omissions will prevent Flow users from using the grid system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog entry in the README describes the feature as "Add grid system" but doesn't mention the percentage positioning feature at all. Since issue #651 specifically requested percentage positioning and that's mentioned in the PR title, the changelog should explicitly mention both features: percentage positioning (
positionUnit="%") and the grid system (positionUnit="grid", etc.).