Test many different encodings#28
Draft
StanFromIreland wants to merge 4 commits intobodograumann:masterfrom
Draft
Test many different encodings#28StanFromIreland wants to merge 4 commits intobodograumann:masterfrom
StanFromIreland wants to merge 4 commits intobodograumann:masterfrom
Conversation
Contributor
Author
|
This is interesting, even on Ubuntu in the CI we create a codec object for unsupported codecs: |
StanFromIreland
commented
Nov 2, 2025
| @unittest.skipUnless(sys.platform.startswith("linux"), "Linux only test") | ||
| def test_encode(self): | ||
| bytestring = "Hallo".encode("T.61") | ||
| bytestring = "Hallo".encode("VISCII") |
Contributor
Author
There was a problem hiding this comment.
I suggest we switch, VISCII is not provided by CPython, and seems to be more cross-platform than T.61.
| try: | ||
| "a".encode(encoding) | ||
| except Exception as e: | ||
| raise AssertionError( |
Owner
There was a problem hiding this comment.
Why not use self.fail here as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.