Skip to content

Support tester.customservice property. #6961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ejjcase wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Support tester.customservice property. #6961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions biz.aQute.tester.junit-platform/src/aQute/tester/junit/platform/Activator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import static aQute.junit.constants.TesterConstants.TESTER_CONTINUOUS;
import static aQute.junit.constants.TesterConstants.TESTER_CONTROLPORT;
import static aQute.junit.constants.TesterConstants.TESTER_CUSTOMSERVICE;
import static aQute.junit.constants.TesterConstants.TESTER_DIR;
import static aQute.junit.constants.TesterConstants.TESTER_NAMES;
import static aQute.junit.constants.TesterConstants.TESTER_PORT;
Expand Down Expand Up @@ -88,11 +89,17 @@ public void start(BundleContext context) throws Exception {
this.context = context;
active = true;

boolean isCustomService = Boolean.valueOf(context.getProperty(TESTER_CUSTOMSERVICE));
if (!Boolean.valueOf(context.getProperty(TESTER_SEPARATETHREAD))
&& Boolean.valueOf(context.getProperty("launch.services"))) {
&& (isCustomService || Boolean.valueOf(context.getProperty("launch.services")))) {
// can't register services on mini framework
Hashtable<String, String> ht = new Hashtable<>();
ht.put("main.thread", "true");
if (isCustomService) {
ht.put("junit.tester", "true");
}
else {
ht.put("main.thread", "true");
}
ht.put(Constants.SERVICE_DESCRIPTION, "JUnit tester");
context.registerService(Runnable.class.getName(), this, ht);
} else {
Expand Down
7 changes: 7 additions & 0 deletions biz.aQute.tester/src/aQute/junit/constants/TesterConstants.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,4 +66,11 @@ public interface TesterConstants {
* well to use this special thread to run all tests on.
*/
String TESTER_SEPARATETHREAD = "tester.separatethread";

/**
* Register the tester {@link java.lang.Runnable} as a service with the
* attribute {@code junit.tester=true}. User code may then obtain the
* service and run then tests when convenient.
*/
String TESTER_CUSTOMSERVICE = "tester.customservice";
}