Skip to content

fix(ci): produce .tar.gz archives for Zed ACP registry compatibility#8054

Merged
DOsinga merged 2 commits intoblock:mainfrom
vincenzopalazzo:claude/sharp-sammet
Mar 26, 2026
Merged

fix(ci): produce .tar.gz archives for Zed ACP registry compatibility#8054
DOsinga merged 2 commits intoblock:mainfrom
vincenzopalazzo:claude/sharp-sammet

Conversation

@vincenzopalazzo
Copy link
Contributor

Summary

  • Adds .tar.gz archive output alongside the existing .tar.bz2 for Linux/macOS CLI builds
  • Updates all release workflows (release, nightly, canary) to include goose-*.tar.gz in published artifacts

Problem

Zed's agent server store (agent_server_store.rs) only supports .tar.gz, .tgz, and .zip when downloading agent binaries:

let asset_kind = if archive_url.ends_with(".zip") {
    AssetKind::Zip
} else if archive_url.ends_with(".tar.gz") || archive_url.ends_with(".tgz") {
    AssetKind::TarGz
} else {
    anyhow::bail!("unsupported archive type in URL: {}", archive_url);
};

Goose currently only publishes .tar.bz2 for Linux/macOS, causing Zed users to get "unsupported archive type in URL" when installing Goose via the ACP registry.

Solution

Produce both .tar.bz2 (backward compat) and .tar.gz (Zed compat) in the build pipeline. This is a minimal change — one extra tar command in build-cli.yml and glob additions in the release workflows.

Once merged and released, the ACP registry entry for Goose can be updated to point to the .tar.gz URLs.

Test plan

  • Verify CI builds produce both .tar.bz2 and .tar.gz artifacts
  • Verify release assets include both archive formats
  • After ACP registry update, verify Zed can install Goose via registry method

Closes #8047

🤖 Generated with Claude Code

…atibility

Zed's agent registry only supports .tar.gz, .tgz, and .zip archives
when downloading agent server binaries. Goose releases currently only
produce .tar.bz2 for Linux/macOS, causing Zed to fail with
"unsupported archive type in URL" when installing Goose via the
ACP registry.

This adds .tar.gz output alongside the existing .tar.bz2 to maintain
backward compatibility while enabling Zed registry integration.

Closes block#8047

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7ed8b43552

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- Rename ARTIFACT to ARTIFACT_ZIP in the Windows packaging step so all
  three upload path variables have a consistent naming scheme and there
  are no empty path entries in the upload-artifact step
- Remove explanatory comment that restated what the tar commands do
- Add goose-*.tar.gz to the Attest build provenance subject-path in
  canary.yml and release.yml so new .tar.gz archives are signed under
  SLSA provenance (addresses Codex review comments)

Signed-off-by: Douwe Osinga <douwe@squareup.com>
Copy link
Collaborator

@DOsinga DOsinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI workflow fixes look good — the .tar.gz archives are a clean addition for Zed/ACP registry compatibility.

Changes pushed to the branch:

  • Renamed ARTIFACTARTIFACT_ZIP in the Windows packaging step so all three upload-artifact path variables are consistently named and no empty entries are passed on either platform
  • Removed the comment in the Linux/macOS packaging step that just restated what the tar commands do
  • Added goose-*.tar.gz to the Attest build provenance subject-path in both canary.yml and release.yml so the new archives are covered by SLSA provenance signatures

@aleclarson
Copy link

Note that tar.bz2 is supported by the ACP registry:
https://github.com/agentclientprotocol/registry/blob/e77c08070ae89d4e76a0169021bf9974ca2ca51c/agent.schema.json#L96

So I would consider this a bug in Zed's implementation, FWIW.

@vincenzopalazzo
Copy link
Contributor Author

vincenzopalazzo commented Mar 23, 2026

Hey @aleclarson, good catch! You are right, the ACP registry schema does support .tar.bz2 — but looking at the Zed codebase, there is no handler for it.

The archive URL matching in agent_server_store.rs only handles .zip, .tar.gz, and .tgz — anything else bails with "unsupported archive type".

The AssetKind enum in github.rs has no TarBz2 variant, and the extraction logic in github_download.rs has no bzip2 decoder at all.

So yeah, producing both formats here is the pragmatic fix — it unblocks Zed users now. Might be worth opening an issue on zed-industries/zed to close this gap on their side too.

@vincenzopalazzo
Copy link
Contributor Author

In the meantime, I also fixed the zed bug zed-industries/zed#52188, so now with the zed fix, we should have the full workflow completed

@vincenzopalazzo vincenzopalazzo requested a review from DOsinga March 25, 2026 09:46
@DOsinga DOsinga added this pull request to the merge queue Mar 26, 2026
Merged via the queue into block:main with commit 2977512 Mar 26, 2026
20 checks passed
michaelneale added a commit that referenced this pull request Mar 26, 2026
* main: (337 commits)
  fix: replace panics with user-friendly errors in CLI session builder (#7901)
  fix: read GOOSE_CONTEXT_LIMIT from config.yaml, not just env vars (#7900)
  fix: deliver truncation notice as separate content block (#7899)
  fix: use platform-appropriate commands in developer extension instructions (#7898)
  fix: replace any with proper SVG types in icon components (#7873)
  chore: remove debug console.log statements, stale comments, and dead code (#8142)
  feat: Gemini OAuth provider (#8129)
  chore(deps): bump picomatch from 2.3.1 to 2.3.2 in /documentation (#8123)
  feat: show installed skills in UI (#7910)
  fix(deps): gate keyring platform features behind target-specific deps (#8039)
  chore(deps): bump yaml from 2.8.2 to 2.8.3 in /evals/open-model-gym/suite (#8124)
  fix: strip message wrapper in CLI session title generation (#7996)
  fix(providers): fall back to configured models when models endpoint fetch fails (#7530)
  chore(deps): bump brace-expansion from 5.0.3 to 5.0.5 in /evals/open-model-gym/suite (#8139)
  fix: prevent Ollama provider from hanging on tool-calling requests (#7723)
  fix: VMware Tanzu Platform provider - bug fixes, streaming, UI improvements (#8126)
  feat: allow GOOSE_CLI_SHOW_THINKING to be set in config.yaml (#8097)
  fix: GitHub Copilot auth fails to open browser in Desktop app (#6957) (#8019)
  fix(ci): produce .tar.gz archives for Zed ACP registry compatibility (#8054)
  feat: add GOOSE_SHOW_FULL_OUTPUT config to disable tool output truncation (#7919)
  ...

# Conflicts:
#	crates/goose/src/providers/formats/openai.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't connect to Goose ACP in Zed

3 participants