fix(ci): produce .tar.gz archives for Zed ACP registry compatibility#8054
fix(ci): produce .tar.gz archives for Zed ACP registry compatibility#8054DOsinga merged 2 commits intoblock:mainfrom
Conversation
cb0e7e9 to
ae6c169
Compare
…atibility Zed's agent registry only supports .tar.gz, .tgz, and .zip archives when downloading agent server binaries. Goose releases currently only produce .tar.bz2 for Linux/macOS, causing Zed to fail with "unsupported archive type in URL" when installing Goose via the ACP registry. This adds .tar.gz output alongside the existing .tar.bz2 to maintain backward compatibility while enabling Zed registry integration. Closes block#8047 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com>
ae6c169 to
7ed8b43
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7ed8b43552
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Rename ARTIFACT to ARTIFACT_ZIP in the Windows packaging step so all three upload path variables have a consistent naming scheme and there are no empty path entries in the upload-artifact step - Remove explanatory comment that restated what the tar commands do - Add goose-*.tar.gz to the Attest build provenance subject-path in canary.yml and release.yml so new .tar.gz archives are signed under SLSA provenance (addresses Codex review comments) Signed-off-by: Douwe Osinga <douwe@squareup.com>
DOsinga
left a comment
There was a problem hiding this comment.
CI workflow fixes look good — the .tar.gz archives are a clean addition for Zed/ACP registry compatibility.
Changes pushed to the branch:
- Renamed
ARTIFACT→ARTIFACT_ZIPin the Windows packaging step so all three upload-artifact path variables are consistently named and no empty entries are passed on either platform - Removed the comment in the Linux/macOS packaging step that just restated what the tar commands do
- Added
goose-*.tar.gzto theAttest build provenancesubject-path in bothcanary.ymlandrelease.ymlso the new archives are covered by SLSA provenance signatures
|
Note that tar.bz2 is supported by the ACP registry: So I would consider this a bug in Zed's implementation, FWIW. |
|
Hey @aleclarson, good catch! You are right, the ACP registry schema does support The archive URL matching in The So yeah, producing both formats here is the pragmatic fix — it unblocks Zed users now. Might be worth opening an issue on |
|
In the meantime, I also fixed the zed bug zed-industries/zed#52188, so now with the zed fix, we should have the full workflow completed |
* main: (337 commits) fix: replace panics with user-friendly errors in CLI session builder (#7901) fix: read GOOSE_CONTEXT_LIMIT from config.yaml, not just env vars (#7900) fix: deliver truncation notice as separate content block (#7899) fix: use platform-appropriate commands in developer extension instructions (#7898) fix: replace any with proper SVG types in icon components (#7873) chore: remove debug console.log statements, stale comments, and dead code (#8142) feat: Gemini OAuth provider (#8129) chore(deps): bump picomatch from 2.3.1 to 2.3.2 in /documentation (#8123) feat: show installed skills in UI (#7910) fix(deps): gate keyring platform features behind target-specific deps (#8039) chore(deps): bump yaml from 2.8.2 to 2.8.3 in /evals/open-model-gym/suite (#8124) fix: strip message wrapper in CLI session title generation (#7996) fix(providers): fall back to configured models when models endpoint fetch fails (#7530) chore(deps): bump brace-expansion from 5.0.3 to 5.0.5 in /evals/open-model-gym/suite (#8139) fix: prevent Ollama provider from hanging on tool-calling requests (#7723) fix: VMware Tanzu Platform provider - bug fixes, streaming, UI improvements (#8126) feat: allow GOOSE_CLI_SHOW_THINKING to be set in config.yaml (#8097) fix: GitHub Copilot auth fails to open browser in Desktop app (#6957) (#8019) fix(ci): produce .tar.gz archives for Zed ACP registry compatibility (#8054) feat: add GOOSE_SHOW_FULL_OUTPUT config to disable tool output truncation (#7919) ... # Conflicts: # crates/goose/src/providers/formats/openai.rs
Summary
.tar.gzarchive output alongside the existing.tar.bz2for Linux/macOS CLI buildsgoose-*.tar.gzin published artifactsProblem
Zed's agent server store (
agent_server_store.rs) only supports.tar.gz,.tgz, and.zipwhen downloading agent binaries:Goose currently only publishes
.tar.bz2for Linux/macOS, causing Zed users to get"unsupported archive type in URL"when installing Goose via the ACP registry.Solution
Produce both
.tar.bz2(backward compat) and.tar.gz(Zed compat) in the build pipeline. This is a minimal change — one extratarcommand inbuild-cli.ymland glob additions in the release workflows.Once merged and released, the ACP registry entry for Goose can be updated to point to the
.tar.gzURLs.Test plan
.tar.bz2and.tar.gzartifactsCloses #8047
🤖 Generated with Claude Code