fix: add skip_canonical_filtering to declarative providers#8052
Open
fix: add skip_canonical_filtering to declarative providers#8052
Conversation
Declarative providers serving arbitrary local models (e.g. LM Studio) have model names that won't match the canonical registry, so filtering them out leaves an empty model list. Add a boolean skip_canonical_filtering field to DeclarativeProviderConfig (defaults false) and honour it in fetch_recommended_models. Set it to true in lmstudio.json so all locally-served models are returned as-is. Fixes the same problem addressed by #8043 and #8001. Signed-off-by: Douwe Osinga <douwe@squareup.com>
This was referenced Mar 21, 2026
added 2 commits
March 21, 2026 15:14
Signed-off-by: Douwe Osinga <douwe@squareup.com>
Signed-off-by: Douwe Osinga <douwe@squareup.com>
Collaborator
Author
|
@nelsonr462 and @octogonz - I think this does what we want to get done here? let me know if not. |
jamadeo
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Declarative providers serving arbitrary local models (e.g. LM Studio) have model names that won't match the canonical registry, so the existing filtering in
fetch_recommended_modelsreturns an empty list.Details
Adds a
skip_canonical_filteringboolean field toDeclarativeProviderConfig(defaultsfalse, so no behaviour change for existing providers). Whentrue,fetch_recommended_modelsreturns all models fromfetch_supported_modelsdirectly without consulting the canonical registry.Sets
skip_canonical_filtering: trueinlmstudio.jsonso locally-served models are listed as-is.This is a clean, minimal fix for the same problem raised in #8043 and #8001 — without name-string hardcoding or a new provider-type enum.
Closes #8043
cc #8001