fix(deps): gate keyring platform features behind target-specific deps#8039
Open
r0x0d wants to merge 1 commit intoblock:mainfrom
Open
fix(deps): gate keyring platform features behind target-specific deps#8039r0x0d wants to merge 1 commit intoblock:mainfrom
r0x0d wants to merge 1 commit intoblock:mainfrom
Conversation
Move platform-specific keyring features to target-gated dependency sections so each OS only pulls in its native backend: - macOS: apple-native - Windows: windows-native - Linux: sync-secret-service The vendored feature remains on the base dependency as it applies cross-platform (libdbus, openssl). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Rodolfo Olivieri <rolivier@redhat.com>
DOsinga
approved these changes
Mar 22, 2026
Collaborator
DOsinga
left a comment
DOsinga
left a comment
There was a problem hiding this comment.
Clean, correct Cargo hygiene fix — moving platform-specific keyring backends to the right [target.'cfg(...)'.dependencies] sections so each OS only pulls in its own native backend. The vendored feature correctly stays on the base dep since it's cross-platform. No concerns, approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move platform-specific keyring features to target-gated dependency sections so each OS only pulls in its native backend:
The vendored feature remains on the base dependency as it applies cross-platform (libdbus, openssl).
Testing
Related Issues
Relates to #ISSUE_ID
Discussion: LINK (if any)
Screenshots/Demos (for UX changes)
Before:
After: