refactor: return errors instead of logging them internally#243
Merged
alecthomas merged 1 commit intomainfrom Mar 31, 2026
Merged
refactor: return errors instead of logging them internally#243alecthomas merged 1 commit intomainfrom
alecthomas merged 1 commit intomainfrom
Conversation
Functions should return errors, not log them internally, so callers retain control over how failures are reported and handled. - cacheBundleSync, refreshExpiration: return error, callers log - handler.go: serveCached returns (bool, error), streamNonOKResponse, streamAndCache, fetchAndCache return error, ServeHTTP logs - host.go: buildTargetURL clone URL by value instead of re-parsing - git.go: serveReadyRepo, serveWithSpool, startClone return error - snapshot.go: serveSnapshotWithSpool, streamSnapshotDirect, writeSnapshotSpool return error - doFetch: remove redundant log (was logging AND returning) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functions should return errors, not log them internally, so callers
retain control over how failures are reported and handled.
streamAndCache, fetchAndCache return error, ServeHTTP logs
writeSnapshotSpool return error
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com