Merged
Conversation
Member
Author
|
in that case, it would be good to extend the CI matrix for MSVC (including /O2 builds) |
Member
Author
pr will be appreciated 😎. closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see: chriskohlhoff/asio#1724
this pr fixes a bug related to asio by using the alignment capability built into
asio::co_composed_futurewith a custom allocator bound to the completion tokenthe union inside
asio::co_composed_futurewill takealignof(allocator_type), andallocator_typewill be the allocator associated with the completion token. therefore, all we need to do is create a simple allocator withalignas(16), after which the compiler will automatically alignasio::co_composed_future::blockby 16 bytes, and the SSEmovapsinstruction, which was incorrectly emitted by the MSVC, will be able to be executed correctly without triggering STATUS_ACCESS_VIOLATION (GP fault)