Skip to content

Skip CLA check for bot accounts#3010

Closed
aconite33 wants to merge 1 commit intostablefrom
fix-cla-bot-skip
Closed

Skip CLA check for bot accounts#3010
aconite33 wants to merge 1 commit intostablefrom
fix-cla-bot-skip

Conversation

@aconite33
Copy link
Copy Markdown
Contributor

Summary

Fixes CLA check failures on automated PRs from bot accounts (e.g. dependabot, renovate).

The existing allowlist field in the CLA assistant action was not matching bot authors correctly, causing PRs like #3009 to fail the CLA check. This adds an explicit bot detection step that:

  1. Checks if the PR author's login ends with [bot]
  2. Sets a success commit status for CLAAssistant when a bot is detected
  3. Skips the CLA assistant action entirely via an additional if condition

This is in addition to the existing org membership skip and the CLA assistant's own allowlist, providing a reliable fallback.

Test plan

  • Merge this PR, then re-run the CLA check on Bump pyjwt from 2.11.0 to 2.12.0 #3009 (dependabot PR) and verify it passes
  • Verify normal CLA flow still works for non-bot, non-member PRs
  • Once validated here, roll out to other org repos

Add a bot detection step that checks if the PR author's login ends
with [bot] (e.g. dependabot[bot], github-actions[bot], renovate[bot]).
When detected, the CLA check is skipped with a success status, and the
CLA assistant action is not invoked at all. This fixes CLA failures on
automated dependency PRs where the allowlist in the CLA assistant
action was not matching correctly.
@aconite33 aconite33 closed this Apr 1, 2026
@aconite33 aconite33 deleted the fix-cla-bot-skip branch April 1, 2026 18:35
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92%. Comparing base (593fe04) to head (802603c).

Additional details and impacted files
@@          Coverage Diff           @@
##           stable   #3010   +/-   ##
======================================
- Coverage      92%     92%   -0%     
======================================
  Files         416     416           
  Lines       34690   34690           
======================================
- Hits        31645   31641    -4     
- Misses       3045    3049    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant