Skip to content

[PM-34009] chore: Create KeychainServiceFacade #2507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KatherineInCode wants to merge 45 commits into
base: main
Choose a base branch
from

Merge branch 'main' into pm-34009/keychain-service-facade

dfca6a1
Select commit
Loading
Failed to load commit list.
Open

[PM-34009] chore: Create KeychainServiceFacade #2507

Merge branch 'main' into pm-34009/keychain-service-facade
dfca6a1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 7, 2026 in 1s

85.99% (-1.09%) compared to 571dd72

View this Pull Request on Codecov

85.99% (-1.09%) compared to 571dd72

Details

Codecov Report

❌ Patch coverage is 96.65236% with 39 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.99%. Comparing base (571dd72) to head (dfca6a1).

Files with missing lines Patch % Lines
...ared/Core/Platform/Services/ServiceContainer.swift 0.00% 15 Missing ⚠️
...Shared/Core/Auth/Services/KeychainRepository.swift 87.30% 8 Missing ⚠️
...SharedKeychain/SharedKeychainRepositoryTests.swift 96.46% 4 Missing ⚠️
...latform/Models/Domain/Mocks/MockKeychainItem.swift 50.00% 3 Missing ⚠️
...d/Core/Auth/Services/KeychainRepositoryTests.swift 97.94% 3 Missing ⚠️
...eKit/SharedKeychain/SharedKeychainRepository.swift 92.59% 2 Missing ⚠️
...enKit/Core/Platform/Services/KeychainService.swift 80.00% 2 Missing ⚠️
...Core/Platform/Services/KeychainServiceFacade.swift 98.24% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2507      +/-   ##
==========================================
- Coverage   87.07%   85.99%   -1.09%     
==========================================
  Files        1859     2086     +227     
  Lines      164172   178692   +14520     
==========================================
+ Hits       142955   153668   +10713     
- Misses      21217    25024    +3807

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov