Conversation
github-actions
bot
added
app:password-manager
fedemkr
changed the title
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2494 +/- ##
==========================================
- Coverage 86.94% 85.80% -1.14%
==========================================
Files 1857 2090 +233
Lines 163782 179123 +15341
==========================================
+ Hits 142394 153702 +11308
- Misses 21388 25421 +4033 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fedemkr
added
innovation
| <string>Use Yubikeys for two-factor authentication.</string> | ||
| <key>NSCameraUsageDescription</key> | ||
| <string>Scan QR codes</string> | ||
| <string>Scan QR codes and payment cards</string> |
There was a problem hiding this comment.
🤔 "Payment cards" sounds a bit weird to my ear here, but I don't have a better suggestion. Might be worth bouncing off of Product?
| "SaveHere" = "Save here"; | ||
| "SaveThisAuthenticatorKeyHereOrAddItToALoginInYourBitwardenApp" = "Save this authenticator key here, or add it to a login in your Bitwarden app."; | ||
| "SaveToBitwarden" = "Save to Bitwarden"; | ||
| "ScanCard" = "Scan Card"; |
There was a problem hiding this comment.
🎨 Should this be title cased ("Scan Card") or sentence cased ("Scan card")?
| final class DefaultCardTextParser: CardTextParser { | ||
| // MARK: Private Constants | ||
|
|
||
| /// Labels printed on cards that should not be interpreted as cardholder names. |
There was a problem hiding this comment.
🤔 Are we going to need to expand this for non-English cards, too? I kinda wonder if there's some way we could pull this list out, and how we can keep it updated well, as we discover new strings for it.
| ) | ||
| } | ||
| } | ||
| case .scanCardButtonTapped: |
There was a problem hiding this comment.
⛏️ I think these should be alphabetized
2 participants
🎟️ Tracking
PM-33989
📔 Objective
Make use of the camera and VisualKit APIs to simplify the process so the user can point the camera to the card and automatically grab all the details (card number, cardholder name, expiry date) from it filling it on the add card view fields.
If more than one cardholder name is detected by the OCR logic, then present a list of options to the user to choose from.
📸 Screenshots
Card.Scanner.Mar-31.MP4