[PM-33569] feat: Handle displaying login request for alert style notification

[matt-livefront]

🎟️ Tracking

PM-33569

📔 Objective

This adds support for receiving alert-style push notifications for login with device.

In the current approach, the backend sends a silent push notification. The app receives this notification in the background and schedules a local notification for the user to see.

When switching to alert-style push notifications, the notification extension (#2444) will first receive the notification and update the contents of the notification. This alert will display automatically. But there's two changes that are needed to support this flow:

• The local notification shouldn't be displayed for the alert-style notification or the user will see duplicate notifications.
• Because the data in the payload of the notification is different, there needs to be a separate path in the app to handle tapping on the alert-style notification.

[claude]

Claude finished @matt-livefront's task in 2m 17s —— View job

---

Code Review: PM-33569 Handle displaying login request for alert style notification

• Gather context and review PR changes
• Review PushNotificationData.swift changes
• Review NotificationService.swift changes
• Review NotificationServiceTests.swift changes
• Post review findings

Summary

This PR cleanly handles the transition from silent push notifications (with local banners) to alert-style push notifications for login-with-device requests. The implementation is well-structured and covers all the necessary paths.

No actionable findings identified. The code looks good:

• PushNotificationData.swift — Added optional id field to LoginRequestPushNotification to support the alert-style notification payload. Clean and minimal.
• NotificationService.swift — Core logic changes are well-organized:
  • isAlertNotification parameter properly gates local notification creation to prevent duplicates
  • New alert notification tap handling in handleNotificationTapped correctly parses the different payload format
  • Same-account login request display logic is properly shared between both notification paths
  • Error handling and guard clauses are appropriate
• NotificationServiceTests.swift — Comprehensive test coverage for all new paths: alert notification receipt, alert notification taps for same/different accounts, and local notification taps for same account.

TODOs are properly tagged with the follow-up ticket (PM-33817) for removing the legacy local notification approach. 👍

[github-actions]

Checkmarx One – Scan Summary & Details – 0ad80e61-4418-4f95-8051-a18362764dfd

Great job! No new security vulnerabilities introduced in this pull request

[codecov]

Codecov Report

❌ Patch coverage is 98.20359% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.89%. Comparing base (e6d1ebd) to head (4ef7db1).
⚠️ Report is 5 commits behind head on main.

Files with missing lines	Patch %	Lines
...d/Core/Platform/Services/NotificationService.swift	95.31%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #2482    +/-   ##
========================================
  Coverage   86.88%   86.89%            
========================================
  Files        1844     1844            
  Lines      163171   163313   +142     
========================================
+ Hits       141769   141908   +139     
- Misses      21402    21405     +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.