[PM-26292] tool: Add script to delete unused Localizable.strings entries#2464
Draft
KatherineInCode wants to merge 6 commits intopm-26293/delete-unused-stringsfrom
Draft
[PM-26292] tool: Add script to delete unused Localizable.strings entries#2464KatherineInCode wants to merge 6 commits intopm-26293/delete-unused-stringsfrom
KatherineInCode wants to merge 6 commits intopm-26293/delete-unused-stringsfrom
Conversation
Contributor
|
Great job! No new security vulnerabilities introduced in this pull request |
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## pm-26293/delete-unused-strings #2464 +/- ##
===================================================================
- Coverage 85.27% 42.38% -42.89%
===================================================================
Files 2063 585 -1478
Lines 175943 31627 -144316
===================================================================
- Hits 150029 13406 -136623
+ Misses 25914 18221 -7693 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-26292
📔 Objective
This builds on #2412 by adding a module that finds unused strings and deletes them. I also did some refactoring of the strings file management into a separate python module.
I also ran the script, and it found 308 unused keys, many of which were identified in #2003. I'm not entirely sure why it's so many, especially of what seem like basic strings, though my guess is that some are used on Android, and a lot of them are detritus from MAUI or earlier that just never got cleaned up.
As noted in #2412, eventually we could have running these scripts be part of the CI process in some way, but currently these are still manual runs.