Conversation
|
New Issues (8)Checkmarx found the following issues in this Pull Request
|
| ::::note | ||
|
|
||
| The dependencies can be installed in your local environment by running the script | ||
| `scripts/prepare-env-rust.sh`. If installing manually, ensure that the versions of the cargo |
There was a problem hiding this comment.
What about windows? They don't run bash scripts.
There was a problem hiding this comment.
Good point. We could have two versions of the script one for Unix and one for Windows. Unless you have alternative suggestions? Not sure if there is any prior art from other repos in the org, where we might have a similar situation. If we go with two flavors of the script, I guess that would be written in powershell.
There was a problem hiding this comment.
Server is one example, it primarily uses powershell since it's cross platform.
There was a problem hiding this comment.
I hesitate to put it in the general Tools page, because that is not specific for clients
There is a spot for this: see docs/getting-started/clients/index.md > Requirements heading. That links out to the general Tools page today, but there's no reason that we can't have information directly under that heading. To me this entire Dependencies section could/should be on that page given that it's part of the monorepo tooling.


🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-34175
📔 Objective
Reference the new Rust env install script in the DN dependencies section.
I hesitate to put it in the general Tools page, because that is not specific for
clients, and the other repos in the project might have different versioning requirements for the cargo binaries or toolchains.📸 Screenshots