Skip to content

ci: fix update revision script#4063

Merged
ematipico merged 4 commits intomainfrom
ci/fix-update-revision-script
Mar 16, 2026
Merged

ci: fix update revision script#4063
ematipico merged 4 commits intomainfrom
ci/fix-update-revision-script

Conversation

@nhedger
Copy link
Member

@nhedger nhedger commented Mar 15, 2026

Summary

This PR fixes the revision update script to only update the biome packages so that they point to the new revision.

It also drops ls-types from the list since its no longer being wrongfully updated.

Generates something like this:

biome_console = { git = "https://github.com/biomejs/biome.git", rev = "fe9ff6b14fd15970a47c7760a47aef08401963e6", version = "0.5.7" }
biome_css_analyze = { git = "https://github.com/biomejs/biome.git", rev = "fe9ff6b14fd15970a47c7760a47aef08401963e6", version = "0.5.7" }
biome_css_parser = { git = "https://github.com/biomejs/biome.git", rev = "fe9ff6b14fd15970a47c7760a47aef08401963e6", version = "0.5.7" }
biome_css_semantic = { git = "https://github.com/biomejs/biome.git", rev = "fe9ff6b14fd15970a47c7760a47aef08401963e6", version = "0.0.0" }
biome_css_syntax = { git = "https://github.com/biomejs/biome.git", rev = "fe9ff6b14fd15970a47c7760a47aef08401963e6", version = "0.5.7" }

@netlify
Copy link

netlify bot commented Mar 15, 2026

Deploy Preview for biomejs ready!

Name Link
🔨 Latest commit 8ba5054
🔍 Latest deploy log https://app.netlify.com/projects/biomejs/deploys/69b70417fc27e1000830959b
😎 Deploy Preview https://deploy-preview-4063--biomejs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nhedger nhedger marked this pull request as ready for review March 15, 2026 19:14
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 15, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 5fa0bff8-88db-4259-88a9-87c9e60386cc

📥 Commits

Reviewing files that changed from the base of the PR and between 366e96a and 8ba5054.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • Cargo.toml
  • scripts/update-revision.sh

Walkthrough

This pull request modifies the dependency management and build configuration. Cargo.toml is reformatted for consistency and removes a pinned dependency on ls-types. The update-revision script is refactored to dynamically discover and update biome-related crate versions using cargo tree and cargo add, replacing the previous direct revision editing approach. The core functionality and build pipeline remain unchanged.

🚥 Pre-merge checks | ✅ 2
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: fixing the update revision script to only update biome packages and remove ls-types.
Description check ✅ Passed The description clearly explains the changes made to the revision update script and provides concrete examples of the generated output.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/fix-update-revision-script
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

CodeRabbit can suggest fixes for GitHub Check annotations.

Configure the reviews.tools.github-checks setting to adjust the time to wait for GitHub Checks to complete.

@ematipico ematipico merged commit ac07cc1 into main Mar 16, 2026
9 checks passed
@ematipico ematipico deleted the ci/fix-update-revision-script branch March 16, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants