-
-
Notifications
You must be signed in to change notification settings - Fork 208
docs: add plugin file scoping (includes) documentation #3993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
chocky335
wants to merge
8
commits into
biomejs:next
Choose a base branch
from
chocky335:docs/plugin-file-scoping
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+67
−11
Open
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
173a17c
docs: add plugin file scoping (includes/excludes) documentation
chocky335 1c143b8
docs: drop excludes, use negated globs in includes
chocky335 bac5488
docs(plugins): address review feedback on file scoping docs
chocky335 cebc481
docs(plugins): clarify glob pattern semantics in file scoping
chocky335 e7d30a2
docs(plugins): describe example and replace file scoping wording
chocky335 fc139c7
docs(reference): replace file scoping wording, mark path required
chocky335 8a84be7
docs(plugins): use precise file extension wording per review
chocky335 dab73f8
docs(reference): document empty includes behavior
chocky335 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our docs, when we provide code examples like here, we follow this pattern, in this order
In this case, we miss a description of the example you added. It should explain which plugin matches which paths
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a paragraph before the example describing which plugin matches which paths.