Skip to content

Change web scraping query to retrieve proper title #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gazayas wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change web scraping query to retrieve proper title #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20046a8
Change web scraping query to retrieve proper title
gazayas Nov 26, 2020
b2b8bf2
Refactor title code
gazayas Nov 26, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions lib/bible_gateway.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def version=(version)
def lookup(passage)
response = Typhoeus.get(passage_url(passage), followlocation: true)
doc = Nokogiri::HTML(response.body)
scrape_passage(doc, @version)
scrape_passage(doc, @version, passage)
end

def old_lookup(passage)
Expand All @@ -81,9 +81,10 @@ def old_passage_url(passage)
"#{CLASSIC_GATEWAY_URL}/passage/?search=#{URI.encode_www_form_component(passage)}&version=#{URI.encode_www_form_component(VERSIONS[version])}"
end

def scrape_passage(doc, version)
def scrape_passage(doc, version, passage)
container = doc.css('div.passage-text')
title = container.css("div.version-#{VERSIONS[version]}.result-text-style-normal.text-html h1 span")[0].content.strip if container.css("div.version-#{VERSIONS[version]}.result-text-style-normal.text-html h1")[0] != nil
title = doc.css(".dropdown-display-text").first.children.first.text
title ||= passage
segment = doc.at('div.passage-text')

segment.search('sup.crossreference').remove # remove cross reference links
Expand Down