Skip to content

First stab at implementing draft-ietf-sidrops-8210bis-14#126

Open
job wants to merge 8 commits intomasterfrom
draft-ietf-sidrops-8210bis-14
Open

First stab at implementing draft-ietf-sidrops-8210bis-14#126
job wants to merge 8 commits intomasterfrom
draft-ietf-sidrops-8210bis-14

Conversation

@job
Copy link
Copy Markdown
Member

@job job commented Aug 7, 2024

Copy link
Copy Markdown
Collaborator

@benjojo benjojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume its still in WIP, but make sure the unit tests are not nulled out before merging :)

@job
Copy link
Copy Markdown
Member Author

job commented Aug 7, 2024

I assume its still in WIP, but make sure the unit tests are not nulled out before merging :)

hah, nice, thanks for pointing that out

@job job requested a review from benjojo August 7, 2024 12:43
@marenamat
Copy link
Copy Markdown
Contributor

while testing against BIRD, we found out that if one doesn't explicitly request -protocol 2, then after BIRD sends Serial Query with verson set to 2, StayRTR replies with Cache Response but version set to 1

supposing that both sides are violating the draft here, section 7, because in this case, StayRTR should either accept version 2, or send Error Report with code 4, and BIRD should, after receiving a different version, probably drop the session as well

@randomthingsandstuff
Copy link
Copy Markdown
Contributor

I wanna revisit this PR in the context of a completed 8210bis if that sounds good. Because we want all that ASPA shit and blahblah.

@job
Copy link
Copy Markdown
Member Author

job commented Nov 16, 2025

I suspect draft-8210bis is now stable and we should implement asap. If we complete the work before WGLC, any feedback we may have still is valuable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants