Skip to content

Limit Pixel 10 to GPU preprocessing without GPU culling#24101

Merged
alice-i-cecile merged 3 commits intobevyengine:mainfrom
SkiFire13:fix-pixel10-sampler-crash
May 4, 2026
Merged

Limit Pixel 10 to GPU preprocessing without GPU culling#24101
alice-i-cecile merged 3 commits intobevyengine:mainfrom
SkiFire13:fix-pixel10-sampler-crash

Conversation

@SkiFire13
Copy link
Copy Markdown
Contributor

@SkiFire13 SkiFire13 commented May 3, 2026 •
edited
Loading

Objective

Solution

  • Limit Pixel 10 to GPU preprocessing without GPU culling

Testing

  • Ran the android example on my Pixel 10

@kfc35 kfc35 added this to the 0.19 milestone May 3, 2026
@kfc35 kfc35 added O-Android Specific to the Android mobile operating system C-Bug An unexpected or incorrect behavior C-Machine-Specific This bug is isolated to specific hardware or driver configurations A-Rendering Drawing game state to the screen labels May 3, 2026
@kfc35 kfc35 added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label May 3, 2026
@github-project-automation github-project-automation Bot moved this to Needs SME Triage in Rendering May 3, 2026
beicause
beicause reviewed May 3, 2026
View reviewed changes
Comment thread crates/bevy_render/src/batching/gpu_preprocessing.rs Outdated
@SkiFire13 SkiFire13 changed the title Exclude Pixel 10 from GPU preprocessing support Limit Pixel 10 to GPU preprocessing without GPU culling May 3, 2026
alice-i-cecile
alice-i-cecile approved these changes May 3, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the right call for now.

@alice-i-cecile alice-i-cecile requested a review from mockersf May 3, 2026 17:30
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 4, 2026
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 4, 2026
Merged via the queue into bevyengine:main with commit 827358a May 4, 2026
40 checks passed
@github-project-automation github-project-automation Bot moved this from Needs SME Triage to Done in Rendering May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

@mockersf mockersf Awaiting requested review from mockersf

+2 more reviewers

@beicause beicause beicause left review comments

@JMS55 JMS55 JMS55 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior C-Machine-Specific This bug is isolated to specific hardware or driver configurations O-Android Specific to the Android mobile operating system S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Rendering
Status: Done

Milestone

0.19

Development

Successfully merging this pull request may close these issues.

5 participants

@SkiFire13 @alice-i-cecile @JMS55 @beicause @kfc35