Use <[T]>::as_chunks{_mut} for exact size chunks#23755
Open
DavidCrossman wants to merge 3 commits intobevyengine:mainfrom
Open
Use <[T]>::as_chunks{_mut} for exact size chunks#23755DavidCrossman wants to merge 3 commits intobevyengine:mainfrom
<[T]>::as_chunks{_mut} for exact size chunks#23755DavidCrossman wants to merge 3 commits intobevyengine:mainfrom
Conversation
kfc35
added
C-Code-Quality
beicause
reviewed
Apr 29, 2026
Comment on lines
+1609
to
+1615
| self.try_indices()? | ||
| .iter() | ||
| .collect::<Vec<usize>>() | ||
| .chunks_exact(3) | ||
| .for_each(|face| per_triangle([face[0], face[1], face[2]], positions, &mut normals)); | ||
| .as_chunks() | ||
| .0 | ||
| .iter() | ||
| .for_each(|&faces| per_triangle(faces, positions, &mut normals)); |
Member
There was a problem hiding this comment.
collect::<Vec<usize>>() can be removed.
Suggested change
| self.try_indices()? | |
| .iter() | |
| .collect::<Vec<usize>>() | |
| .chunks_exact(3) | |
| .for_each(|face| per_triangle([face[0], face[1], face[2]], positions, &mut normals)); | |
| .as_chunks() | |
| .0 | |
| .iter() | |
| .for_each(|&faces| per_triangle(faces, positions, &mut normals)); | |
| match self.try_indices()? { | |
| Indices::U16(vec) => vec.as_chunks().0.iter().for_each(|&chunk| { | |
| per_triangle(chunk.map(|i| i as usize), positions, &mut normals) | |
| }), | |
| Indices::U32(vec) => vec.as_chunks().0.iter().for_each(|&chunk| { | |
| per_triangle(chunk.map(|i| i as usize), positions, &mut normals) | |
| }), | |
| } |
Comment on lines
2219
to
2230
| let iterator = match indices { | ||
| Indices::U16(vec) => FourIterators::First( | ||
| vec.as_slice() | ||
| .chunks_exact(3) | ||
| .flat_map(move |indices| indices_to_triangle(vertices, indices)), | ||
| ), | ||
| Indices::U32(vec) => FourIterators::Second( | ||
| vec.as_slice() | ||
| .chunks_exact(3) | ||
| .flat_map(move |indices| indices_to_triangle(vertices, indices)), | ||
| ), | ||
| }; |
Member
There was a problem hiding this comment.
as_slice().chunks_exact(3) can be replaced with as_chunks::<3>().0
Co-authored-by: Luo Zhihao <luo_zhihao@outlook.com>
beicause
approved these changes
Apr 29, 2026
Breakdown-Dog
approved these changes
May 3, 2026
beicause
added
S-Ready-For-Final-Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
unwraps and bounds checks.Solution
<[T]>::chunks{_mut}and<[T]>::chunks_exact{_mut}where the size is exact with<[T]>::as_chunks{_mut}.Testing
cargo run -p ci -- compile