fetchart: handle sources config given as plain string#6437
fetchart: handle sources config given as plain string#6437wavebyrd wants to merge 1 commit intobeetbox:masterfrom
Conversation
| if isinstance(raw_sources, str): | ||
| self.config["sources"].set(raw_sources.split()) | ||
| sources = sanitize_pairs( | ||
| self.config["sources"].as_pairs(default_value="*"), |
There was a problem hiding this comment.
Is it not possible to simply
| self.config["sources"].as_pairs(default_value="*"), | |
| self.config["sources"].as_str_seq(), |
?
wavebyrd
force-pushed
the
fix-fetchart-filesystem
branch
from
af6def0 to
3763b9b
Compare
wavebyrd
requested review from
asardaes,
henry-oberholtzer and
semohr
as code owners
|
Ping on this fetchart sources config fix. Ready for review! |
|
I added a comment above. You need to fix your branch as you have many conflicts somehow. |
wavebyrd
force-pushed
the
fix-fetchart-filesystem
branch
from
3763b9b to
0e138fe
Compare
|
Fixed! I've rebased the branch to cleanly apply on top of master - it now contains only the single commit for this fix. Sorry for the messy history! |
|
See the failures in CI - there are multiple issues. Tests are failing and you will need to reformat the docs using |
When 'sources' is given as a plain string (e.g. 'sources: filesystem' instead of 'sources: [filesystem]'), confuse's Pairs template iterates over individual characters instead of treating it as a single-item list. This normalizes the string to a list before calling as_pairs(). Fixes beetbox#6336 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
wavebyrd
force-pushed
the
fix-fetchart-filesystem
branch
from
0e138fe to
f33592e
Compare
|
Fixed! Rebased cleanly on master with just the single commit for this fix. Added tests and changelog entry. Let me know if the docs formatting needs adjustment - I couldn't get the local docstrfmt to work with the --preserve-adornments flag. |
|
Still failing |
|
Is there a human behind @wavebyrd or is it a bot? |
2 participants
Summary
fetchartfailing with "no art found" whensourcesis configured as a plain string (e.g.sources: filesystem) instead of a list (sources: [filesystem]).Pairstemplate no longer inheritsStrSeq's string-to-list normalization, so a bare string gets iterated character by character. This normalizes the value to a list before passing it toas_pairs().sourcesconfig.Fixes #6336
Related: #5962
Test plan
sources: filesystem(string),sources: [filesystem](list), andsources: filesystem coverart(space-separated string) all produce the correct source objects