Skip to content

Open updates card automatically when there are less than 3 updates #1478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kolunmi merged 1 commit into from
May 11, 2026
Merged

Open updates card automatically when there are less than 3 updates #1478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/bz-updates-card.blp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ template $BzUpdatesCard: Adw.Bin {

Adw.ExpanderRow expander_row {
title: bind $format_update_count(template.state as <$BzStateInfo>.available-updates) as <string>;
notify::expanded => $on_expander_expanded_cb();

[suffix]
Box {
Expand Down
16 changes: 16 additions & 0 deletions src/bz-updates-card.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ struct _BzUpdatesCard

GPtrArray *app_rows;
GtkWidget *runtimes_row;

gboolean has_closed;
};

G_DEFINE_FINAL_TYPE (BzUpdatesCard, bz_updates_card, ADW_TYPE_BIN)
Expand All @@ -65,6 +67,7 @@ static guint signals[LAST_SIGNAL];
static char *format_update_count (gpointer object, GListModel *updates);
static void update_all_cb (GtkButton *button, BzUpdatesCard *self);
static void update_runtimes_cb (GtkButton *button, BzUpdatesCard *self);
static void on_expander_expanded_cb (AdwExpanderRow *row, GParamSpec *pspec, BzUpdatesCard *self);
static gboolean filter_runtimes (BzEntry *entry, BzUpdatesCard *self);
static void on_available_updates_changed (BzUpdatesCard *self, GParamSpec *pspec, BzStateInfo *state);
static void on_runtimes_changed (GtkFilterListModel *model, guint position, guint removed, guint added, BzUpdatesCard *self);
Expand Down Expand Up @@ -256,6 +259,9 @@ repopulate_expander_row (BzUpdatesCard *self)
self->runtimes_row = build_runtimes_row (self);
adw_expander_row_add_row (self->expander_row, self->runtimes_row);
on_runtimes_changed (self->runtimes_filter_model, 0, 0, 0, self);

if (!self->has_closed)
adw_expander_row_set_expanded (self->expander_row, n_items <= 3);
}

static void
Expand Down Expand Up @@ -358,6 +364,7 @@ bz_updates_card_class_init (BzUpdatesCardClass *klass)
gtk_widget_class_bind_template_child (widget_class, BzUpdatesCard, runtimes_filter_model);
gtk_widget_class_bind_template_callback (widget_class, format_update_count);
gtk_widget_class_bind_template_callback (widget_class, update_all_cb);
gtk_widget_class_bind_template_callback (widget_class, on_expander_expanded_cb);
}

static void
Expand Down Expand Up @@ -474,6 +481,15 @@ update_runtimes_cb (GtkButton *button,
g_signal_emit (self, signals[SIGNAL_UPDATE], 0, store);
}

static void
on_expander_expanded_cb (AdwExpanderRow *row,
GParamSpec *pspec,
BzUpdatesCard *self)
{
if (!adw_expander_row_get_expanded (row))
self->has_closed = TRUE;
}

static gboolean
filter_runtimes (BzEntry *entry,
BzUpdatesCard *self)
Expand Down
Loading