Conversation
…ce. demonstrate how anyhow can be applied to connect as a separate sub-function
…on handling since we map None to Duration::MAX
…f session in one place
… session block shutdown
…Result it makes more sense just to do the connect inline
…ake everything read a little cleaner
Member
|
Went through all the commits. Small commits gave me good insight into your thought process and how code reviews are done. I removed mentions of session timeout and made a few more changes to the README. Also, I noticed the CI was building and packaging echo-server, so changed that too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mdmzfzl I tried to do single purpose commits so that you could follow my thought process.
Be sure to test try the various test scenarios you were trying previously to make sure the behaviors / logging / errors still work as you expect them to!