Set keyboard brightness to fixed values of 0, 1, 25 and 100.#5424
Set keyboard brightness to fixed values of 0, 1, 25 and 100.#5424sockbot wants to merge 1 commit intobasecamp:devfrom
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks for the feedback! To clarify, this PR (#5424) is specifically the PR that addresses the keyboard backlight issue using the fixed values of 0, 1, 25, and 100 percent. You mentioned that you've already created a PR that specifically addresses the keyboard backlight issue. Could you point me to that PR? If it's a separate PR that supersedes this one, I can close this PR and let the discussion happen there instead. Regarding your other feedback about setting minimum brightness to 1 instead of 0 — I agree that including 1 as a minimum level is important for cases where users want some backlight but not full off. The current values (0, 1, 25, 100) do include 1 as the lowest "on" level. Would you like me to adjust the brightness levels further? Let me know if you'd prefer this PR to focus on a different change, or if I should keep the keyboard backlight changes here. |
ad4f418 to
02a7332
Compare
Fixes #5414
This PR sets keyboard backlight keys to use the fixed values of 0, 1, 25, and 100 percent corresponding to off, low, medium, and high.
Limiting the backlight settings to off, low, medium and high on my hardware provides a simplified and practical user experience to get an appropriate backlight level in fewer presses compared to steps of 10%. In addition, since the backlight strength is not linear, more discrete options do not add functionality (values of 50-100 are almost identical).
I chose the values of 0, 1, 25 and 100 because these subjectively looked like equidistant levels of brightness across the range.
Because this PR only exposes keyboard backlight values of off, low, medium and high I replaced the 100% scale bar with a simple text display:
Testing
Tested on MacBook Air 2014. Testing on additional hardware is welcome (and desired).