alacritty.toml fallback for legacy themes without colors.toml#5404
Open
prepin wants to merge 1 commit intobasecamp:devfrom
Open
alacritty.toml fallback for legacy themes without colors.toml#5404prepin wants to merge 1 commit intobasecamp:devfrom
prepin wants to merge 1 commit intobasecamp:devfrom
Conversation
prepin
force-pushed
the
generate-colors-from-alacritty
branch
from
ae24c51 to
f6658b9
Compare
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
prepin
force-pushed
the
generate-colors-from-alacritty
branch
from
f6658b9 to
bdae84c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Omarchy Manual's Extra Themes page currently showcases 109 themes of which roughly half (53 themes) do not have a
colors.tomlfile and therefore they do not support the newer Omarchy templating engine that generates application themes in~/.config/omarchy/themed.Idea is to add fallback for such legacy themes that reconstructs
colors.tomlin case it is missing using colors defined inalacritty.toml(which is always present).I've run an exhaustive test on each of 53 legacy themes and found no issues with all but one theme (Midnight theme, missing part of the palette).
P.S. Two themes listed on the Extra Themes page have already been deleted from GitHub -- Green Hakkar and Torrentz Hydra are gone.
Inspiration: Omazed project (Zed theme generator for Omarchy).