refactor(tx-manager): make nonce manager generic over provider trait#1400
Merged
refactor(tx-manager): make nonce manager generic over provider trait#1400
Conversation
Collaborator
✅ Heimdall Review Status
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
Review SummaryClean refactor — no issues found. The change correctly introduces a generic parameter
|
refcell
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Makes
NonceManagergeneric over a provider trait (P: Provider) instead of being hardcoded toRootProvider.NonceManagernow takes a type parameterPand storesprovider: Pinstead ofprovider: RootProviderimplblock is bounded byP: Provider, so any provider implementation can be usedSimpleTxManagerconcretizes the type asNonceManager<RootProvider>to preserve its existing APIRootProviderimport moved from the main module to the test module where it's still needed for the test-onlyseededconstructorThis decouples the nonce manager from a specific provider type, enabling easier testing with mock providers and reuse in contexts that don't use
RootProvider.Notes to reviewers
Pure refactor — no behavioral changes. All existing tests pass without modification (only type annotations updated).
How has it been tested?
Existing unit and integration tests in
crates/utilities/tx-manager/continue to pass.Change management (definitions)
type=routine
risk=low
impact=sev5
Backwards Compatibility (learn more)
backwards_compatible=true
automerge=false