Skip to content

ci: install autopoint for aya integration tests#340

Merged
vadorovsky merged 2 commits intoaya-rs:mainfrom
Brskt:fix-aya-integration-tests
Jan 30, 2026
Merged

ci: install autopoint for aya integration tests#340
vadorovsky merged 2 commits intoaya-rs:mainfrom
Brskt:fix-aya-integration-tests

Conversation

@Brskt
Copy link
Copy Markdown
Contributor

@Brskt Brskt commented Jan 29, 2026

Summary


This change is Reviewable

aya now requires libbpf-sys for integration tests, which needs
autopoint to build.
Comment thread .github/workflows/ci.yml
- rust: nightly
llvm: 21
exclude-features: llvm-20,rust-llvm-20
# TODO: enable when llvm-sys 221.x is released
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be released, mind updating this?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping the version here would trigger a domino of other issues I'm solving in #328, like:

  • necessity of bumping aya-rustc-llvm-proxy
  • using the new IR read helper (only for LLVM 22)
  • adjusting the features in Cargo.toml

I'm fine with the temporary comment here.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go for it

Comment thread .github/workflows/ci.yml Outdated
# Keep LLVM 21 here until aya-rs/llvm-project has a 22.x branch.
- toolchain:
rust: nightly
rust: nightly-2025-12-31
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the latest nightly before rust-lang/rust#150722? Must be close to 2026-01-28

Also link to the PR from the comment so we can easily navigate to the merge commit to see if it's in beta.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Brskt Brskt force-pushed the fix-aya-integration-tests branch from 8237c3f to c492f59 Compare January 29, 2026 14:50
@tamird
Copy link
Copy Markdown
Member

tamird commented Jan 29, 2026

thanks for the PR! holding off on this in case we can get the llvm-sys update today.

@vadorovsky
Copy link
Copy Markdown
Member

Actually, it seems like we need to merge this first, to make the llvm-sys upgrade green, lol:
https://github.com/aya-rs/bpf-linker/actions/runs/21526263173/job/62030588553?pr=328

The nightly pinning here is good enough to unblock this chicken-egg problem. I'll merge it now and rebase unpin nightly in #328

@vadorovsky vadorovsky merged commit 567f8c1 into aya-rs:main Jan 30, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants