refactor(codec): expose base64 encode/decode#1545
Open
nabetti1720 wants to merge 1 commit into
Open
Conversation
b86a896 to
b6ad8ba
Compare
b6ad8ba to
6478154
Compare
Collaborator
|
Thanks for the PR! There are some timezone related changes that i think sliped in. Could you please also run criterion benches as well to see raw performance since a lot of this is called from rust fns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if available)
n/a
Description of changes
@aws-sdk, LLRT replaces@smithy/util-base64with a native implementation.Buffer.from(), but by replacing it with the simd-compatible base64 encode/decode already provided byllrt_encoding, we can further improve speed.Uint8Array.[from|to]Base64()appears to perform better when the input is aUint8Array, its performance drops significantly as the input length increases. In contrast,llrt:codec.[decodeFrom|encodeTo]Base64()exhibits relatively minor degradation, sollrt:codec.[decodeFrom|encodeTo]Base64()was chosen for this pull request.Benchmark result
benchmarks/mitata/decode_from_base64.js
benchmarks/mitata/encode_to_base64.js
Checklist
tests/unitand/or in Rust for my feature if neededmake fixto format JS and apply Clippy auto fixesmake checktypes/directoryBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.