Set --default-toolchain, use --locked and re-build#183
Merged
zhuofuAMZ merged 1 commit intoawslabs:mainfrom Mar 11, 2026
Merged
Set --default-toolchain, use --locked and re-build#183zhuofuAMZ merged 1 commit intoawslabs:mainfrom
--default-toolchain, use --locked and re-build#183zhuofuAMZ merged 1 commit intoawslabs:mainfrom
Conversation
zhuofuAMZ
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR re-builds the
Dockerfilefor Text Embeddings Inference v1.8.0 and v1.8.2 as per the recently reported CVEs, and in the process identifies an issue with therust-toolchain.tomlbeing missing which was preventing us from re-building the givenDockerfiles on earlier versions (see huggingface/text-embeddings-inference#842).Additionally, this PR also adds the
--lockedflag in thechef cookandcargo buildcommands to ensure that theCargo.lockfile is used, ensuring that the image will still build anytime in the future.Then, as per CVE patching, re-building and pushing to AWS EC2 and scanning with AWS Inspector, shows that there are no vulnerabilities at all in neither of those after re-building.
Finally, note that the CPU
Dockerfiles didn't need to modify anything given that those were not affected by therust-toolchain.tomlas we're using therustcversion installed on the base image, which didn't change.TL;DR Re-building fixed all the existing CVEs on all the reported containers, as of March 06, 2026, ~14:00:00 (UTC+01).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.