Closed
Conversation
This change adds sorting to profiles and roles when running `aws sso configure` listing them in ascending alphabetical order by default (case insensitive).
Newly added tests were accidentally merged into the wrong location. This puts them under the right test class (`TestConfigureSSOCommand`).
This takes into account email address as well, which is used when printing the output.
The existing tests were written using the old unittest framework. This change updates them to use the newer pytest/fixture framework. It also adds tests for sorting the accounts by account ID and email address.
Refactor shared setup for account sorting tests into a reusable fixture to improve readability and reduce repeated boilerplate.
ashovlin
approved these changes
Apr 3, 2026
Member
Author
|
Closing in favor of #10149. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#6108
Description of changes:
Continuation of #10149. Updates tests to conform to new test suite, refactors sorting method.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.