fix: persist hostname-override flag to context#630
Merged
miparnisari merged 1 commit intoauthzed:mainfrom Mar 30, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #630 +/- ##
==========================================
- Coverage 42.31% 42.29% -0.02%
==========================================
Files 38 38
Lines 6102 6109 +7
==========================================
+ Hits 2582 2584 +2
- Misses 3260 3264 +4
- Partials 260 261 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
miparnisari
requested changes
Mar 29, 2026
Contributor
miparnisari
left a comment
miparnisari
left a comment
There was a problem hiding this comment.
- Please rebase off
main - Please amend the following unit tests:
TestTokenWithOverrideandTestTokenAnyValue
otherwise, LGTM
ivanauth
force-pushed
the
fix/issue-593-persist-hostname-override
branch
from
3681aa7 to
162236a
Compare
Contributor
Author
|
Done, thanks! |
ivanauth
commented
Mar 30, 2026
Contributor
Author
ivanauth
left a comment
ivanauth
left a comment
There was a problem hiding this comment.
Rebased onto main and added HostnameOverride coverage to both TestTokenWithOverride and TestTokenAnyValue. Ready for re-review.
The --hostname-override flag was not persisted when setting a context, requiring users to pass it on every command. This adds hostname-override to the Token struct and saves it alongside other TLS-related flags like --insecure and --no-verify-ca during `zed context set`. Subcommands now read hostname-override from the stored context, with CLI flags still taking precedence when explicitly provided. Signed-off-by: ivanauth <ivan@authzed.com>
ivanauth
force-pushed
the
fix/issue-593-persist-hostname-override
branch
from
162236a to
696541c
Compare
miparnisari
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #593
Persists
--hostname-overrideto zed context storage, matching the existing pattern for--insecureand--no-verify-ca. CLI flag still overrides stored value when explicitly set.