vswitch: add vswitch component

[JDuchniewicz]

Adds a vswitch component following #636

Allows for connecting up to 62 clients and one TX/RX Virt pair with the vswitch. Tested with PR: au-ts/libvmm#207 and depends on microkit_sdf_gen PR: au-ts/microkit_sdf_gen#31

The support for connecting vswitches back to back might be added later.

[midnightveil]

You appear to have broken all the echo server examples per CI.

It would be good to add an example/CI test for this. Same applies to libVMM itself.

(My other question: is vswitch a driver or an (Lions)OS component...?)

[JDuchniewicz]

You appear to have broken all the echo server examples per CI.

It would be good to add an example/CI test for this. Same applies to libVMM itself.

Yes, I will add the necessary test, example is in libVMM. Should we also have one here?

(My other question: is vswitch a driver or an (Lions)OS component...?)

I don't foresee running it alone, it should be a plug-and-play component chosen during writing of the meta.py file.

[midnightveil]

I don't foresee running it alone, it should be a plug-and-play component chosen during writing of the meta.py file.

What I mean is "does it make more sense as part of LionsOS than sDDF"?

[JDuchniewicz]

I don't foresee running it alone, it should be a plug-and-play component chosen during writing of the meta.py file.

What I mean is "does it make more sense as part of LionsOS than sDDF"?

I don't know where we draw the line between, this is "driver/should be in sDDF" and "this is too high-level for sDDF". I presume current components are crucial enough to be here. This is somewhere in-between as it is an optional system component.

[Kswin01]

I'll have a proper read through the vswitch implementation later, but a few nitpicks of the surrounding updates

[JDuchniewicz]

@Courtney3141 I think it's prudent to first merge this, then create a new PR for the new example with 2 echo_server's as there might be a substantial amount of new files. Also, libvmm depends on it and not necessarily on the presence of the sddf example.

[Courtney3141]

@Courtney3141 I think it's prudent to first merge this, then create a new PR for the new example with 2 echo_server's as there might be a substantial amount of new files. Also, libvmm depends on it and not necessarily on the presence of the sddf example.

Agreed.

[Courtney3141]

Should have given you enough feedback to work on here! This is a great implementation, most my comments are just about small details. I really like how you have structured your vswitch code in particular.