Skip to content

CI: Fix test_json failure on single-precision (float32) #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bettio merged 1 commit into from
Apr 4, 2026
+27 −3
Merged

CI: Fix test_json failure on single-precision (float32) #2257

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 27 additions & 3 deletions tests/libs/estdlib/test_json.erl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ test() ->
ok.

test_y() ->
lists:foreach(fun run_y_test/1, y_tests()),
lists:foreach(fun run_y_test/1, filter_precision(y_tests())),
ok.

test_n() ->
Expand All @@ -74,7 +74,7 @@ test_t() ->
ok.

test_y_roundtrip() ->
lists:foreach(fun run_y_roundtrip/1, y_tests()),
lists:foreach(fun run_y_roundtrip/1, filter_precision(y_tests())),
ok.

test_i_roundtrip() ->
Expand Down Expand Up @@ -125,6 +125,25 @@ resolve({external_term, Enc}) ->
resolve(Term) ->
Term.

%% Filter out test cases containing float values that exceed single-precision range.
filter_precision(Tests) ->
case is_single_precision() of
true -> [T || T = {Name, _, _} <- Tests, not requires_double(Name)];
false -> Tests
end.

is_single_precision() ->
case erlang:system_info(machine) of
"BEAM" -> false;
"ATOM" -> erlang:system_info(avm_floatsize) =:= 4
end.

%% Test cases with float values exceeding float32 range (~3.4e38).
requires_double("y_number.json") -> true;
requires_double("y_number_real_exponent.json") -> true;
requires_double("y_number_real_fraction_exponent.json") -> true;
requires_double(_) -> false.

to_bin(IoData) -> iolist_to_binary(IoData).

test_decode_basic() ->
Expand Down Expand Up @@ -380,7 +399,12 @@ test_encode_basic() ->
<<"9007199254740993">> = to_bin(json:encode(9007199254740993)),

<<"1.0">> = to_bin(json:encode(1.0)),
<<"3.14">> = to_bin(json:encode(3.14)),
case is_single_precision() of
true ->
<<"3.1400001">> = to_bin(json:encode(3.14));
false ->
<<"3.14">> = to_bin(json:encode(3.14))
end,
<<"-2.5">> = to_bin(json:encode(-2.5)),
<<"-0.0">> = to_bin(json:encode(-0.0)),

Expand Down
Loading