Skip to content

perf: ImportDelcaration Dirname #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
mgfalzon wants to merge 4 commits into
base: master
Choose a base branch
from
+6 −6
Draft

perf: ImportDelcaration Dirname #1891

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e504deb
perf: reduce resolver overhead in babel plugin
May 8, 2026
d02f098
revert: remove resolveRequest caching from resolve-binding.ts
May 8, 2026
49f41e8
refactor: combine fileDir and isRelative computation in ImportDeclara…
May 8, 2026
85e5854
refactor: simplify to single relativeFileDir variable
May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/babel-plugin/src/babel-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,18 +240,18 @@ export default declare<State>((api) => {
},
ImportDeclaration(path, state) {
const userLandModule = path.node.source.value;
// Only relative imports need dirname resolution; compute it once upfront.
// null means "not a relative import or no filename" — skip resolution entirely.
const relativeFileDir =
state.filename && userLandModule[0] === '.' ? dirname(state.filename) : null;
const isCompiledModule = this.importSources.some((compiledModuleOrigin) => {
if (compiledModuleOrigin === userLandModule) {
return true;
}

if (
state.filename &&
userLandModule[0] === '.' &&
userLandModule.endsWith(basename(compiledModuleOrigin))
) {
if (relativeFileDir && userLandModule.endsWith(basename(compiledModuleOrigin))) {
// Relative import that might be a match, resolve the relative path and compare.
const fullpath = resolve(dirname(state.filename), userLandModule);
const fullpath = resolve(relativeFileDir, userLandModule);
return fullpath === compiledModuleOrigin;
}

Expand Down
Loading