Skip to content

fix: add 10s timeout to registryValidation to prevent indefinite hang #2047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zhaog100 wants to merge 2 commits into
base: master
Choose a base branch
from
+13 −2
Open

fix: add 10s timeout to registryValidation to prevent indefinite hang #2047

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9088e17
fix: add 10s timeout to registryValidation to prevent indefinite hang
zhaog100 Mar 17, 2026
e8ef44a
chore: add changeset for registry timeout fix
zhaog100 Mar 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/warm-swans-peel.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@asyncapi/cli": patch
---

fix: add 10s timeout to registry validation to prevent indefinite hang
10 changes: 8 additions & 2 deletions src/utils/generate/registry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,17 @@
export async function registryValidation(registryUrl?: string, registryAuth?: string, registryToken?: string) {
if (!registryUrl) { return; }
try {
const response = await fetch(registryUrl as string);
const controller = new AbortController();
const timeout = setTimeout(() => controller.abort(), 10000);
const response = await fetch(registryUrl as string, { signal: controller.signal });

Check warning on line 14 in src/utils/generate/registry.ts

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

This assertion is unnecessary since it does not change the type of the expression. 


See more on https://sonarcloud.io/project/issues?id=asyncapi_cli&issues=AZz7p_OxjFzH0WTZ5ZxO&open=AZz7p_OxjFzH0WTZ5ZxO&pullRequest=2047
clearTimeout(timeout);
if (response.status === 401 && !registryAuth && !registryToken) {
throw new Error('You Need to pass either registryAuth in username:password encoded in Base64 or need to pass registryToken');
}
} catch {
} catch (error: any) {
if (error.name === 'AbortError') {
throw new Error(`Registry URL timed out after 10s: ${registryUrl}. Check the URL or network connectivity.`);
}
throw new Error(`Can't fetch registryURL: ${registryUrl}`);
}
}
Loading