Skip to content

fix: prevent browserslist config resolution error with pnpm #2043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pannous wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: prevent browserslist config resolution error with pnpm #2043

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion src/domains/services/generator.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,17 @@ export class GeneratorService extends BaseService {
? spinner()
: { start: () => null, stop: (message: string) => logs.push(message) };
s.start('Generation in progress. Keep calm and wait a bit');

// Prevent browserslist from walking directories to find a config file.
// When installed via pnpm, the global bin directory contains a shell wrapper
// named "browserslist" that gets mistakenly parsed as a browserslist config,
// causing: "Unknown browser query 'basedir=$(dirname ...'". Setting this env
// var makes browserslist use it directly instead of searching for config files.
const previousBrowserslist = process.env.BROWSERSLIST;
if (!process.env.BROWSERSLIST) {
process.env.BROWSERSLIST = 'defaults';
}

try {
await generator.generateFromString(asyncapi.text(), {
...genOption,
Expand All @@ -114,10 +125,17 @@ export class GeneratorService extends BaseService {
} catch (err: unknown) {
s.stop('Generation failed');
const errorMessage = getErrorMessage(err, 'Generation failed');
const diagnostics = err && typeof err === 'object' && 'diagnostics' in err
const diagnostics = err && typeof err === 'object' && 'diagnostics' in err
? (err as { diagnostics?: unknown[] }).diagnostics as Parameters<typeof this.createErrorResult>[1]
: undefined;
return this.createErrorResult(errorMessage, diagnostics);
} finally {
// Restore original BROWSERSLIST env var
if (previousBrowserslist === undefined) {
delete process.env.BROWSERSLIST;
} else {
process.env.BROWSERSLIST = previousBrowserslist;
}
}
s.stop(
this.getGenerationSuccessMessage(output),
Expand Down
Loading