Upgrade bundled pjproject to 2.17.#1889
Conversation
|
cherry-pick-to: 20 |
github-actions
Bot
added
pr-submit-tests-failed
and removed
pr-submit-testing-in-progress
labels
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
Bot
added
the
has-pr-checklist
|
Workflow Check failed |
github-actions
Bot
added
pr-submit-testing-in-progress
and removed
pr-submit-tests-failed
labels
silentindark
force-pushed
the
master-issue-1888
branch
from
67320d1 to
76790d1
Compare
github-actions
Bot
added
pr-submit-testing-in-progress
pr-submit-tests-failed
and removed
pr-submit-testing-in-progress
labels
|
Workflow Check failed |
github-actions
Bot
added
pr-submit-testing-in-progress
and removed
pr-submit-tests-failed
labels
silentindark
force-pushed
the
master-issue-1888
branch
from
b7c59f3 to
d4b1a87
Compare
github-actions
Bot
added
pr-submit-testing-in-progress
pr-submit-tests-failed
and removed
pr-submit-testing-in-progress
labels
|
Workflow Check failed |
gtjoseph
left a comment
gtjoseph
left a comment
There was a problem hiding this comment.
@silentindark Please squash the commits and address the checklist items.
silentindark
force-pushed
the
master-issue-1888
branch
from
d4b1a87 to
96a8459
Compare
github-actions
Bot
added
pr-submit-testing-in-progress
and removed
pr-submit-tests-failed
labels
silentindark
force-pushed
the
master-issue-1888
branch
from
96a8459 to
9f9a099
Compare
silentindark
force-pushed
the
master-issue-1888
branch
from
1a10bbc to
e46940b
Compare
github-actions
Bot
added
pr-submit-testing-in-progress
and removed
pr-submit-testing-in-progress
labels
Resolves: asterisk#1888 UserNote: Bundled pjproject has been upgraded to 2.17. For more information about what is included in this release, see the pjproject Github page: https://github.com/pjsip/pjproject/releases/tag/2.17
silentindark
force-pushed
the
master-issue-1888
branch
from
e46940b to
4ea367a
Compare
github-actions
Bot
added
pr-submit-testing-in-progress
and removed
pr-submit-testing-in-progress
labels
silentindark
changed the title
Squashed into one commit. Could you also check how the checklist items look now? |
gtjoseph
dismissed
github-actions[bot]’s stale review
Pull Request Checklist Complete
github-actions
Bot
added
pr-submit-tests-failed
and removed
pr-submit-testing-in-progress
labels
|
Workflow Check failed |
github-actions
Bot
added
cherry-pick-testing-in-progress
|
Workflow CPCheck failed |
|
I'm concerned about the channels/pjsip/transfers/blind_transfer/caller_direct_media test since it is failing in all branches on this PR. |
jcolp
left a comment
jcolp
left a comment
There was a problem hiding this comment.
Marking as request changes due to my prior comment about the failing test.
|
I am still investigating the issue with the channels/pjsip/transfers/blind_transfer/caller_direct_media test, but currently have no luck. Any assistance or help would be appreciated. |
I'm looking at it. It may not be related. |
Actually, it is related. I've run the test a few times under pjproject 2.16 and it's passed every time. I then ran it a few times under 2.17 and it's failed every time. Leave this with us. We'll figure it out. |
|
pjsip/pjproject#4765 changed the state machine so we no longer get the transaction terminated event we were looking for. We're looking at workarounds. |
|
It looks like I was thinking in the right direction. In addition, this pull request is marked as “Backward incompatibility” on the release summary page. |
3 participants
Resolves: #1888
UserNote: Bundled pjproject has been upgraded to 2.17. For more
information about what is included in this release, see the
pjproject Github page: https://github.com/pjsip/pjproject/releases/tag/2.17