fix: preserve capital letters in group names and dismiss stale version banner#593
Open
Myasir92 wants to merge 1 commit intoasheshgoplani:mainfrom
Open
Conversation
…n banner Group/session names with capital letters were being forced to lowercase in their paths via strings.ToLower(), causing display issues. Removed the forced lowercasing so paths now preserve the original casing. Also fixed the stale version update banner that persisted after updating agent-deck via terminal while the TUI was running. Added cache invalidation after successful updates and periodic re-checks (every 5 minutes) in the TUI to auto-dismiss the banner. Committed by Muhammad Yasr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #594
strings.ToLower()from path generation inCreateGroup,CreateSubgroup, andRenameGroupso that group paths preserve the original casing (e.g., "MyProject" → path "MyProject" instead of "myproject").InvalidateCache()that deletes the update cache after a successfulagent-deck update, and added a periodic re-check (every 5 minutes) in the TUI so the yellow banner auto-dismisses when the binary has been updated externally (e.g., via terminal orbrew upgrade).Files Changed
internal/session/groups.go— removedstrings.ToLower()from 3 path-generation sitesinternal/update/update.go— addedInvalidateCache()+ called it after successful updateinternal/ui/home.go— addedlastUpdateCheckfield, periodic re-check tick, and banner dismissal logicinternal/session/groups_test.go— updated path expectations to match case-preserving behaviorcmd/agent-deck/group_cmd_test.go— updated path expectations to match case-preserving behaviorTest plan
go test ./internal/session/...— all group tests passgo test ./cmd/agent-deck/...— all group reorder tests passgo test ./internal/update/...— update tests pass🤖 Generated with Claude Code