Add patch-package support for opal-compiler Logger extension#1760
Open
nzinfo wants to merge 2 commits intoasciidoctor:mainfrom
Open
Add patch-package support for opal-compiler Logger extension#1760nzinfo wants to merge 2 commits intoasciidoctor:mainfrom
nzinfo wants to merge 2 commits intoasciidoctor:mainfrom
Conversation
- Add patch-package as dev dependency - Generate patch for opal-logger to support Asciidoctor's LoggerManager options - Add postinstall script to automatically apply patches on npm install - Fixes npm run test:types by ensuring proper Logger level and program name 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds patch-package support to fix compatibility issues with the opal-compiler Logger implementation, enabling proper integration with Asciidoctor's
LoggerManager options.
Changes
Problem Fixed
The original opal-compiler Logger implementation had a rigid constructor that only accepted a pipe parameter. This prevented Asciidoctor from passing custom
LoggerManager options like :progname, :formatter, and :level.
The patch extends the Logger constructor to:
Testing
This change fixes
npm run test:types&npm run test:nodeby ensuring proper Logger level and program name configuration when Asciidoctor initializes the Logger