Skip to content

chore(deps): build against Asciidoctor 2.0.26#1758

Open
ggrossetie wants to merge 2 commits intoasciidoctor:mainfrom
ggrossetie:asciidoctor-2-0-26
Open

chore(deps): build against Asciidoctor 2.0.26#1758
ggrossetie wants to merge 2 commits intoasciidoctor:mainfrom
ggrossetie:asciidoctor-2-0-26

Conversation

@ggrossetie
Copy link
Member

No description provided.

@ggrossetie
Copy link
Member Author

ggrossetie commented Nov 21, 2025

@mojavelinux Something changed in the logger and some tests no longer pass. It seems that the options are being ignored:

it('should be able to get logger\'s info', () => {
  const defaultLogger = asciidoctor.LoggerManager.getLogger()
  expect(defaultLogger.getLevel()).to.equal(0) // was 2
  expect(defaultLogger.getFormatter().$$class.displayName).to.equal('::Formatter') // was ::BasicFormatter
  expect(defaultLogger.getProgramName()).to.equal(Opal.nil) // was 'asciidoctor'
  expect(defaultLogger.getMaxSeverity()).to.equal(undefined) // was 3
})

I guess that's because Opal doesn't support kwargs ? https://github.com/opal/opal/blob/master/stdlib/logger.rb#L40-L44

@ggrossetie
Copy link
Member Author

Upstream issue: opal/opal#2771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant