Scope css so it doesn't mess sites up#171
Open
rtpHarry wants to merge 1 commit intoarielsalminen:masterfrom
Open
Scope css so it doesn't mess sites up#171rtpHarry wants to merge 1 commit intoarielsalminen:masterfrom
rtpHarry wants to merge 1 commit intoarielsalminen:masterfrom
Conversation
As soon as somebody drops this into their site it will affect all buttons. It might go unnoticed and cause problems. The button has an ID so this change will prevent the demo "leaking" when dropped into a real site. I normally stay away from ids but there should only be one and the current css is never going to be used on a live site either so you might modify it either way around but this one stops the leak.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As soon as somebody drops this into their site it will affect all buttons. It might go unnoticed and cause problems.
The button has an ID so this change will prevent the demo "leaking" when dropped into a real site. I normally stay away from ids but there should only be one and the current css is never going to be used on a live site either so you might modify it either way around but this one stops the leak.