Skip to content

feat(gitops-engine): show and format detailed field changes in StatefulSet immutable field errors#25171

Open
aali309 wants to merge 3 commits intoargoproj:masterfrom
aali309:reportAndFormatViolatedFieldError
Open

feat(gitops-engine): show and format detailed field changes in StatefulSet immutable field errors#25171
aali309 wants to merge 3 commits intoargoproj:masterfrom
aali309:reportAndFormatViolatedFieldError

Conversation

@aali309
Copy link
Copy Markdown
Contributor

@aali309 aali309 commented Nov 4, 2025

Fixes: #21209
Part of: #21209
Replaces: argoproj/gitops-engine#654

This PR Improves error messages when attempting to modify immutable fields in StatefulSets by showing exactly which fields changed and their before/after values.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Before the change:

Screenshot 2025-11-05 at 1 02 21 PM

After the change:

Screenshot 2025-11-05 at 1 00 10 PM

@bunnyshell
Copy link
Copy Markdown

bunnyshell bot commented Nov 4, 2025

❌ Preview Environment undeployed from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@aali309 aali309 self-assigned this Nov 4, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.44%. Comparing base (e77acec) to head (63422cc).
⚠️ Report is 583 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #25171      +/-   ##
==========================================
- Coverage   62.44%   62.44%   -0.01%     
==========================================
  Files         351      351              
  Lines       49463    49463              
==========================================
- Hits        30888    30885       -3     
- Misses      15609    15614       +5     
+ Partials     2966     2964       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aali309 aali309 marked this pull request as ready for review November 5, 2025 18:06
@aali309 aali309 requested a review from a team as a code owner November 5, 2025 18:06
@aali309 aali309 force-pushed the reportAndFormatViolatedFieldError branch 2 times, most recently from c8b37ac to dbb9c63 Compare November 7, 2025 19:47
@aali309 aali309 force-pushed the reportAndFormatViolatedFieldError branch 2 times, most recently from 160e03a to a27602c Compare November 21, 2025 17:27
@aali309 aali309 force-pushed the reportAndFormatViolatedFieldError branch 2 times, most recently from 44662fb to c39b331 Compare December 1, 2025 20:10
Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>
@aali309 aali309 force-pushed the reportAndFormatViolatedFieldError branch from c39b331 to 63422cc Compare December 4, 2025 00:26
@reggie-k reggie-k added this to the v3.4 milestone Dec 14, 2025
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been marked as stale because it has had no activity for 90 days. Please comment if this is still relevant.

@github-actions github-actions bot added the Stale No activity for over 90 days label Mar 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stale No activity for over 90 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants