feat(gitops-engine): show and format detailed field changes in StatefulSet immutable field errors#25171
Open
aali309 wants to merge 3 commits intoargoproj:masterfrom
Open
feat(gitops-engine): show and format detailed field changes in StatefulSet immutable field errors#25171aali309 wants to merge 3 commits intoargoproj:masterfrom
aali309 wants to merge 3 commits intoargoproj:masterfrom
Conversation
❌ Preview Environment undeployed from BunnyshellAvailable commands (reply to this comment):
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #25171 +/- ##
==========================================
- Coverage 62.44% 62.44% -0.01%
==========================================
Files 351 351
Lines 49463 49463
==========================================
- Hits 30888 30885 -3
- Misses 15609 15614 +5
+ Partials 2966 2964 -2 ☔ View full report in Codecov by Sentry. |
c8b37ac to
dbb9c63
Compare
160e03a to
a27602c
Compare
44662fb to
c39b331
Compare
Signed-off-by: Atif Ali <atali@redhat.com>
Signed-off-by: Atif Ali <atali@redhat.com>
c39b331 to
63422cc
Compare
Contributor
|
This pull request has been marked as stale because it has had no activity for 90 days. Please comment if this is still relevant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #21209
Part of: #21209
Replaces: argoproj/gitops-engine#654
This PR Improves error messages when attempting to modify immutable fields in StatefulSets by showing exactly which fields changed and their before/after values.
Checklist:
Before the change:
After the change: