Skip to content

test: updating e2e hook finalizer#24215

Closed
agaudreault wants to merge 13 commits intoargoproj:masterfrom
agaudreault:fix-hook-delete-finalizer
Closed

test: updating e2e hook finalizer#24215
agaudreault wants to merge 13 commits intoargoproj:masterfrom
agaudreault:fix-hook-delete-finalizer

Conversation

@agaudreault
Copy link
Copy Markdown
Member

@agaudreault agaudreault commented Aug 20, 2025

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
…inalizer

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@bunnyshell
Copy link
Copy Markdown

bunnyshell bot commented Aug 20, 2025

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

  • 🚀 /bns:deploy to deploy the environment

@agaudreault agaudreault changed the title test updating finalizer test: updating finalizer Aug 20, 2025
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault agaudreault added this to the v3.2 milestone Sep 2, 2025
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 2, 2025

Codecov Report

❌ Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 60.23%. Comparing base (8c3b78e) to head (7a45cf0).
⚠️ Report is 1004 commits behind head on master.

Files with missing lines Patch % Lines
cmd/argocd/commands/app.go 45.45% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #24215      +/-   ##
==========================================
+ Coverage   60.20%   60.23%   +0.02%     
==========================================
  Files         348      348              
  Lines       59918    59921       +3     
==========================================
+ Hits        36074    36092      +18     
+ Misses      20951    20939      -12     
+ Partials     2893     2890       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@agaudreault agaudreault changed the title test: updating finalizer test: updating e2e hook finalizer Sep 2, 2025
@agaudreault agaudreault modified the milestones: v3.2, v3.3 Dec 5, 2025
@agaudreault
Copy link
Copy Markdown
Member Author

Implemented in #25916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant