Implementation of AOX3000 oxygen sensor#24510
Open
SvenArke wants to merge 1 commit intoarendst:developmentfrom
Open
Implementation of AOX3000 oxygen sensor#24510SvenArke wants to merge 1 commit intoarendst:developmentfrom
SvenArke wants to merge 1 commit intoarendst:developmentfrom
Conversation
Deine Commit-Nachricht Deine Commit-Nachricht Deine Commit-Nachricht Deine Commit-Nachricht Deine Commit-Nachricht Remove language.rar
s-hadinger
requested changes
Mar 1, 2026
| GPIO_TELEINFO_ENABLE, // Teleinfo Enable Receive Pin | ||
| GPIO_LMT01, // LMT01 input counting pin | ||
| GPIO_IEM3000_TX, GPIO_IEM3000_RX, // IEM3000 Serial interface | ||
| GPIO_AOX_RX, GPIO_AOX_TX, // AOX3000Z01 UART interface |
Collaborator
There was a problem hiding this comment.
You can't insert a new GPIO here or it will break the numbers for all following GPIOs and break configuration for all Tasmota devices
| int Aox_reinit_count = 0; | ||
|
|
||
| // Frame parser state | ||
| uint8_t Aox_buf[32]; |
Collaborator
There was a problem hiding this comment.
Do you really need to permanently use RAM for this? Or could you move it to local variables so it is allocated on the stack?
Comment on lines
+50
to
+56
| float Aox_oxygen = NAN; | ||
| uint8_t Aox_status = 0; | ||
| uint32_t Aox_last_valid = 0; | ||
| bool Aox_ready = false; | ||
| int8_t Aox_rx_pin = -1; | ||
| uint32_t Aox_last_data = 0; | ||
| int Aox_reinit_count = 0; |
Collaborator
There was a problem hiding this comment.
Could you please put all this in a struct so it's cleaner and allows to compact memory.
Comment on lines
+192
to
+194
| const char *status_str = (Aox_status == 0x01) ? "Error" : | ||
| (Aox_status == 0x02) ? "Warmup" : | ||
| (Aox_status == 0x03) ? "Normal" : "Unknown"; |
Collaborator
There was a problem hiding this comment.
You need to encapsulate the string literals in PSTR() for ESP8266 or they are allocated in the main memory
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Implementation of AOX3000 oxygen sensor.
https://robu.in/wp-content/uploads/2023/01/20250417142952388.pdf
Checklist: