Skip to content

feat(raft): add versioned proto definitions (kiwi.raft.v1)#263

Open
guozhihao-224 wants to merge 1 commit intomainfrom
feat/raft-proto-versioning
Open

feat(raft): add versioned proto definitions (kiwi.raft.v1)#263
guozhihao-224 wants to merge 1 commit intomainfrom
feat/raft-proto-versioning

Conversation

@guozhihao-224
Copy link
Copy Markdown
Collaborator

Summary

  • Add proto3 definitions with versioned package kiwi.raft.v1 for RaftCoreService, RaftAdminService, RaftClientService, RaftMetricsService
  • Add build.rs with tonic-build configuration using versioned descriptor filename (kiwi.raft.v1_descriptor.bin)
  • Update lib.rs to include raft_proto module with versioned proto package

This is PR 1/5 in a series to migrate the gRPC Raft Network implementation from feat/raft:

  1. Proto definitions + build config (this PR)
  2. gRPC error types → base: this branch
  3. gRPC network layer with retry → base: PR ci: check code and pr title, pr labels #2
  4. Type conversion + log_id tracking → base: PR Optimize: 降低lru_cache中trim的时间复杂度 #3
  5. Cluster management scripts → base: PR kiwi-rs 第一阶段任务 #4

Test plan

  • Verify proto files define correct services and messages
  • Verify build.rs compiles proto with kiwi.raft.v1 package
  • Verify lib.rs correctly includes the versioned proto module

🤖 Generated with Claude Code

- Add proto3 definitions with versioned package (kiwi.raft.v1) for
  RaftCoreService, RaftAdminService, RaftClientService, RaftMetricsService
- Add build.rs with versioned descriptor filename
- Update lib.rs to include raft_proto module with versioned package

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 18, 2026

Warning

Rate limit exceeded

@guozhihao-224 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 30 minutes and 42 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 30 minutes and 42 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 85728e9b-a044-430e-805f-bcd750c3fbfe

📥 Commits

Reviewing files that changed from the base of the PR and between 5e51942 and ebf95f9.

📒 Files selected for processing (6)
  • src/raft/build.rs
  • src/raft/proto/admin.proto
  • src/raft/proto/client.proto
  • src/raft/proto/raft.proto
  • src/raft/proto/types.proto
  • src/raft/src/lib.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/raft-proto-versioning

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant