Open
Conversation
There was a couple spots we were leaving around tempdirs
jglogan
reviewed
Mar 31, 2026
| try? FileManager.default.removeItem(at: tempDir) | ||
| throw error | ||
| } | ||
| // Register for cleanup in deinit (only needed when the zstd path didn't already set it) |
Contributor
There was a problem hiding this comment.
We added the tempDecompressedFile specifically because we needed to try to uncompress zstd before invoking libarchive (with either the uncompressed zstd file or the original file if not zstd).
Here it looks like we're writing ZIP-format data into a temp directory created by the call but subsequently owned by the user when init returns? If the data's in the temp directory, why would we need to set tempDecompressedFile for this case?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a couple spots we were leaving around tempdirs