fix(exec): enforce permissions for non-root exec user#1381
Closed
KevinSailema wants to merge 1 commit intoapple:mainfrom
Closed
fix(exec): enforce permissions for non-root exec user#1381KevinSailema wants to merge 1 commit intoapple:mainfrom
KevinSailema wants to merge 1 commit intoapple:mainfrom
Conversation
Drop elevated process capabilities when exec is requested with an explicit non-root user. Add a CLI regression test that validates /etc/shadow access is denied for exec -u nobody. Refs: apple#1352
Member
|
This is not the right fix, we just need caps support in this project in general. We're working to get this out shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop elevated process capabilities when exec is requested with an explicit non-root user.
Add a CLI regression test that validates /etc/shadow access is denied for exec -u nobody.
Refs: #1352
Type of Change
Motivation and Context
Issue #1352 reports that container exec with an explicit non-root user could still read privileged files such as /etc/shadow.
Although uid and gid were switched correctly, elevated process capabilities were still effectively allowing access.
This change drops elevated capabilities when exec is requested with an explicit non-root user, so file permission checks follow expected Unix and Docker semantics.
Testing